Add frame processor support for audio streams #533
+46
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianshijing-lk
approved these changes
Dec 2, 2025
theomonnom
reviewed
Dec 2, 2025
theomonnom
reviewed
Dec 2, 2025
davidzhao
approved these changes
Dec 2, 2025
| owned_buffer_info = audio_event.frame_received.frame | ||
| frame = AudioFrame._from_owned_info(owned_buffer_info) | ||
| if self._processor is not None: | ||
| frame = self._processor._process(frame) |
theomonnom
approved these changes
Dec 4, 2025
Comment on lines
+11
to
+16
| @property | ||
| @abstractmethod | ||
| def is_enabled(self) -> bool: ... | ||
|
|
||
| @abstractmethod | ||
| def set_enabled(self, enable: bool): ... |
Member
There was a problem hiding this comment.
Do you know if using a property would work? It seems more python idiomatic
@property
@abstractmethod
def enabled(self) -> bool: ...
@enabled.setter
@abstractmethod
def enabled(self, value: bool) -> None: ...
Member
There was a problem hiding this comment.
Can be used like:
processor.enabled = False
processor.enabled = True
Comment on lines
18
to
28
| @abstractmethod | ||
| def _update_stream_info( | ||
| self, | ||
| *, | ||
| room_name: str, | ||
| participant_identity: str, | ||
| publication_sid: str, | ||
| ): ... | ||
|
|
||
| @abstractmethod | ||
| def _update_credentials(self, *, token: str, url: str): ... |
Member
There was a problem hiding this comment.
nit: If this is called by an external event, maybe we can call those events like this?
So it is obvious for the users implementing them that this is external.
def on_stream_info_updated()
def on_credentials_updated()
| def _process(self, frame: T) -> T: ... | ||
|
|
||
| @abstractmethod | ||
| def _close(self): ... |
Member
There was a problem hiding this comment.
I think it's OK for close to be public
Suggested change
| def _close(self): ... | |
| def close(self): ... |
Contributor
Author
There was a problem hiding this comment.
I was thinking close would rather be an internal method that we call to end the lifecycle of a processor.
Users would be expected to disable it with processor.enabled = False.
theomonnom
reviewed
Dec 4, 2025
Co-authored-by: Théo Monnom <theo.8bits@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.